Messages in this thread | | | Date | Sat, 14 Aug 2010 22:38:30 -0700 (PDT) | Subject | Re: [xfrm_user] BUG: sleeping function called from invalid context | From | David Miller <> |
| |
From: Herbert Xu <herbert@gondor.apana.org.au> Date: Fri, 13 Aug 2010 11:36:58 -0400
> Luca Tettamanti <kronos.it@gmail.com> wrote: >> >> xfrm_user_policy takes read_lock(&xfrm_km_lock) before calling >> xfrm_compile_policy (via km->compile_policy), which in turn calls >> xfrm_policy_alloc with GFP_KERNEL. > > Thanks for discovering this bug, it only took 8 years :)
We stumble over one of these every so often don't we? :)
> > xfrm: Use GFP_ATOMIC in xfrm_compile_policy > > As xfrm_compile_policy runs within a read_lock, we cannot use > GFP_KERNEL for memory allocations. > > Reported-by: Luca Tettamanti <kronos.it@gmail.com> > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks Herbert.
| |