lkml.org 
[lkml]   [2010]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] kconfig: Fix variable name typo in streamline_config.pl.
    From
    Date
    When I added "use strict;" to streamline_config.pl, I saw following
    warnings.

    > Global symbol "%prompt" requires explicit package name at
    scripts/kconfig/streamline_config.pl line 183.
    > Global symbol "%prompt" requires explicit package name at
    scripts/kconfig/streamline_config.pl line 368.

    Let's fix it.
    (Note: prompts[] is defined at line 123 but never used. This seems
    typo.)

    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Toralf Foerster <toralf.foerster@gmx.de>
    Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>

    Signed-off-by: Hiromu Yakura <hiromu1996@gmail.com>
    ---
    scripts/kconfig/streamline_config.pl | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/scripts/kconfig/streamline_config.pl
    b/scripts/kconfig/streamline_config.pl
    index c70a27d..d74363f 100644
    --- a/scripts/kconfig/streamline_config.pl
    +++ b/scripts/kconfig/streamline_config.pl
    @@ -178,7 +178,7 @@ sub read_kconfig {
    # configs without prompts must be selected
    } elsif ($state ne "NONE" && /^\s*tristate\s\S/) {
    # note if the config has a prompt
    - $prompt{$config} = 1;
    + $prompts{$config} = 1;

    # Check for if statements
    } elsif (/^if\s+(.*\S)\s*$/) {
    @@ -363,7 +363,7 @@ while ($repeat) {
    parse_config_dep_select $depends{$config};
    }

    - if (defined($prompt{$config}) || !defined($selects{$config})) {
    + if (defined($prompts{$config}) || !defined($selects{$config})) {
    next;
    }

    --
    1.7.0.4




    \
     
     \ /
      Last update: 2010-08-15 06:15    [W:0.023 / U:1.760 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site