lkml.org 
[lkml]   [2010]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] Input: fix faulty XXinput_* calls
From
On Thu, Aug 12, 2010 at 18:22, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> From: Daniel Mack <daniel@caiaq.de>
>
> They've been introduced by 987a6c02 ("Input: switch to input_abs_*()
> access functions") and they appear to be some kind of debug left-over.
>
> [Dmitry Torokhov: these are my fault - I added XX prefixes in places where
>  I wanted to do additional review of the code but failed to actually do
>  that in these particular instances.]
>
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> ---
>
>  drivers/input/joystick/amijoy.c  |    2 +-

Thanks, amijoy.c compiles now.

But hil_kbd.c still doesn't compile:

> diff --git a/drivers/input/keyboard/hil_kbd.c b/drivers/input/keyboard/hil_kbd.c
> index ddd5afd..dcc86b9 100644
> --- a/drivers/input/keyboard/hil_kbd.c
> +++ b/drivers/input/keyboard/hil_kbd.c
> @@ -235,7 +235,7 @@ static void hil_dev_handle_ptr_events(struct hil_dev *ptr)
>                        if (val < input_abs_min(dev, ABS_X + i))
>                                input_abs_set_min(dev, ABS_X + i, val);
>                        if (val > input_abs_max(dev, ABS_X + i))

error: implicit declaration of function ‘input_abs_max’.

And indeed, input_abs_max() does not exist, while hil_kbd.c has 4 callers.

Gr{oetje,eeting}s,
                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-08-14 23:55    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site