lkml.org 
[lkml]   [2010]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] input: mouse: add qci touchpad driver
Hi Shubhrajyoti,

>> +
>> +gpio_request_fail:
>> + input_unregister_device(context->qcitp_dev);
>> + context->qcitp_dev = NULL;
>> +
>> +register_fail:
>> + input_free_device(context->qcitp_dev);
> You may like to revisit the use of free after unregister.
>

That looks OK, because qcitp_dev is set to NULL before this call.

---Trilok Soni
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.


\
 
 \ /
  Last update: 2010-08-13 11:37    [W:0.075 / U:0.884 seconds]
©2003-2014 Jasper Spaans. Advertise on this site