lkml.org 
[lkml]   [2010]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv8 04/13] USB: gadget: mass_storage: moved strings handling code to composite
    On Thu, 12 Aug 2010, David Brownell wrote:

    > Looks OK, but I can't test or give it
    > a detailed review just now. An ACK from
    > Alan would be nice.

    There's nothing obviously wrong with this change. However based on all
    the preceding discussion, I now think the best approach may be _never_
    to make up a fake serial number. Use the module parameter, if any, and
    otherwise issue a warning and don't have a serial number string
    descriptor (even though that violates the spec).

    At this point it should be easy to write a patch to implement and
    document the new behavior, for both file-storage and mass-storage.

    Alan Stern



    \
     
     \ /
      Last update: 2010-08-13 17:17    [W:0.039 / U:122.860 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site