Messages in this thread | | | Subject | Re: [patch] usb/serial/ssu100: uninitialized variable | Date | Fri, 13 Aug 2010 08:58:24 -0400 (EDT) | From | (Bill Pemberton) |
| |
> > GCC complains about the original code, because we're using an > unintialized variable "flag". I think we should be setting flag based > on the UART_LSR_BRK_ERROR_BITS but I'm not sure... I don't have this > hardware. Probably passing TTY_NORMAL is better than the current code? >
I took that function from ftdi_sio and stripped a lot out of it while developing the driver. I see I missed adding back in the logic dealing with setting flag correctly. I'll work up a patch to properly deal with it.
-- Bill
| |