Messages in this thread | | | Date | Thu, 12 Aug 2010 02:31:41 -0700 | From | Joel Becker <> | Subject | Re: [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of list_for_each_entry loop cursor |
| |
On Thu, Aug 12, 2010 at 07:46:13AM +0200, Julia Lawall wrote:
> This seems a bit ugly to me, since it exposes the implementation of the > list abstraction. What about the following:
Actually, we're going to go back to the original list_for_each() and list_entry() version. It's a well understood idiom. We're also going to re-audit the rest of the patch that changed list_for_each() to list_for_each_entry(), just in case we missed another semantic error.
Joel
--
Life's Little Instruction Book #30
"Never buy a house without a fireplace."
Joel Becker Consulting Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127
| |