Messages in this thread | | | From | Andreas Schwab <> | Subject | Re: [PATCH] partitions: fix build error in ibm partition detection code | Date | Thu, 12 Aug 2010 10:53:38 +0200 |
| |
Heiko Carstens <heiko.carstens@de.ibm.com> writes:
> - strlcat(tmp, sizeof(tmp), "(nonl)", PAGE_SIZE); > + snprintf(tmp, sizeof(tmp), "(nonl)"); > + strlcat(state->pp_buf, tmp, PAGE_SIZE);
What's the point of tmp and snprintf if it just creates a copy of a constant string?
strlcat(state->pp_buf, "(nonl)", PAGE_SIZE);
Andreas.
-- Andreas Schwab, schwab@redhat.com GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E "And now for something completely different."
| |