lkml.org 
[lkml]   [2010]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] checkpatch: check for incorrect permissions
    On Thu, 12 Aug 2010 10:45:45 +0530
    Rabin Vincent <rabin.vincent@stericsson.com> wrote:

    > Throw an error when a source file has been given execute permissions
    > using the mode change line present in git diffs. Also alow the filename
    > matching to use the "diff" line in addition to the "+++" line, since the
    > mode change lines appear before any "+++" lines.
    >
    > Cc: Andy Whitcroft <apw@canonical.com>
    > Acked-by: Linus Walleij <linus.walleij@stericsson.com>
    > Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com>
    > ---
    > scripts/checkpatch.pl | 10 +++++++++-
    > 1 files changed, 9 insertions(+), 1 deletions(-)
    >
    > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    > index 2039acd..4c35cb9 100755
    > --- a/scripts/checkpatch.pl
    > +++ b/scripts/checkpatch.pl
    > @@ -1308,7 +1308,7 @@ sub process {
    > $here = "#$realline: " if ($file);
    >
    > # extract the filename as it passes
    > - if ($line=~/^\+\+\+\s+(\S+)/) {
    > + if ($line=~/^\+\+\+\s+(\S+)/ || $line=~/^diff\s.*?(\S+)$/) {

    Breakage. This causes the false warning:

    WARNING: patch prefix 'drivers' exists, appears to be a -p0 patch

    to be emitted when processing the below patch:



    From: Dan Carpenter <error27@gmail.com>

    copy_to_user() returns the number of bytes remaining but we want to return
    a negative error code on errors.

    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Cc: "Michael H. Warfield" <mhw@wittsend.com>
    Cc: Greg KH <greg@kroah.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    ---

    drivers/char/ip2/ip2main.c | 2 ++
    1 file changed, 2 insertions(+)

    diff -puN drivers/char/ip2/ip2main.c~ip2-return-efault-on-copy_to_user-errors drivers/char/ip2/ip2main.c
    --- a/drivers/char/ip2/ip2main.c~ip2-return-efault-on-copy_to_user-errors
    +++ a/drivers/char/ip2/ip2main.c
    @@ -2930,6 +2930,8 @@ ip2_ipl_ioctl (struct file *pFile, UINT
    if ( pCh )
    {
    rc = copy_to_user(argp, pCh, sizeof(i2ChanStr));
    + if (rc)
    + rc = -EFAULT;
    } else {
    rc = -ENODEV;
    }
    _


    \
     
     \ /
      Last update: 2010-08-12 23:05    [W:0.021 / U:30.524 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site