lkml.org 
[lkml]   [2010]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: 2.6.36: Sound stop working
    On Thu, Aug 12, 2010 at 1:20 PM, Linus Torvalds
    <torvalds@linux-foundation.org> wrote:
    >
    > So I suspect it's not sound that is broken at all, but pulseaudio that
    > got broken by the fanotify changes.

    Confirmed. That broken commit 3bcf3860a4ff9bb doesn't even boot for me
    (looks like a stack smash recursion), and the commit to "fix" it
    (c1e5c954020e12) is really too ugly to live.

    I think we need to totally undo the whole "struct file" thing, and
    just admit that it was a mistake. The code really wants a "struct
    path", and using a struct file screws up all the refcounting and is
    just not right.

    The fact that dentry_open() may have some problem needs to be fixed
    -there- rather than make the callers do crazy things that they don't
    want to do and can't do sanely.

    Linus


    \
     
     \ /
      Last update: 2010-08-12 23:05    [W:0.027 / U:31.120 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site