Messages in this thread | | | Date | Thu, 12 Aug 2010 15:24:19 +0200 | From | Robert Richter <> | Subject | Re: [PATCH] perf, x86: try to handle unknown nmis with running perfctrs |
| |
On 10.08.10 15:24:28, Cyrill Gorcunov wrote: > On Tue, Aug 10, 2010 at 09:05:41PM +0200, Robert Richter wrote: > > On 10.08.10 13:24:51, Cyrill Gorcunov wrote: > > > > > It gets masked on NMI arrival, at least for some models (Core Duo, P4, > > > P6 M and I suspect more theh that, that was the reason oprofile has > > > it, also there is a note in SDM V3a page 643). > > > > Yes, that's right, I never noticed that. Maybe it is better to > > implement the apic write it in model specific code then. > > > > Perhaps we can make it simplier I think, ie like it was before -- we just > move it under your new DIE_NMIUNKNOWN, in separate patch of course. Though > I'm fine with either way.
I do not understand why you want to put this in the 'unknown' path. Isn't it necessary to unmask the vector with every call of the nmi handler?
-Robert
> > (actually it's interesting to know wouldn't we leave lvt masked when > we hit 'second delayed nmi has arrived' situation, I guess we didn't > hit it before in real yet :-) > > > -Robert > > > > -- > > Advanced Micro Devices, Inc. > > Operating System Research Center > > > -- Cyrill > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
-- Advanced Micro Devices, Inc. Operating System Research Center
| |