lkml.org 
[lkml]   [2010]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[096/111] ext4: Make sure the MOVE_EXT ioctl cant overwrite append-only files
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Theodore Ts'o <tytso@mit.edu>

    commit 1f5a81e41f8b1a782c68d3843e9ec1bfaadf7d72 upstream.

    Dan Roseberg has reported a problem with the MOVE_EXT ioctl. If the
    donor file is an append-only file, we should not allow the operation
    to proceed, lest we end up overwriting the contents of an append-only
    file.

    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    Cc: Dan Rosenberg <dan.j.rosenberg@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    fs/ext4/move_extent.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/fs/ext4/move_extent.c
    +++ b/fs/ext4/move_extent.c
    @@ -958,6 +958,9 @@ mext_check_arguments(struct inode *orig_
    return -EINVAL;
    }

    + if (IS_IMMUTABLE(donor_inode) || IS_APPEND(donor_inode))
    + return -EPERM;
    +
    /* Ext4 move extent does not support swapfile */
    if (IS_SWAPFILE(orig_inode) || IS_SWAPFILE(donor_inode)) {
    ext4_debug("ext4 move extent: The argument files should "



    \
     
     \ /
      Last update: 2010-08-12 02:33    [W:0.030 / U:0.308 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site