Messages in this thread Patch in this message | | | Date | Wed, 11 Aug 2010 17:05:26 -0700 | From | Greg KH <> | Subject | [11/67] Staging: panel: Prevent double-calling of parport_release - fix oops. |
| |
2.6.35-stable review patch. If anyone has any objections, please let us know.
------------------
From: Peter Huewe <peterhuewe@gmx.de>
commit 060132ae42cce3f9d2fd34d9a17b98362b44b9f9 upstream.
This patch prevents the code from calling parport_release and parport_unregister_device twice with the same arguments - and thus fixes an oops.
Rationale: After the first call the parport is already released and the handle isn't valid anymore and calling parport_release and parport_unregister_device twice isn't a good idea.
Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/staging/panel/panel.c | 2 ++ 1 file changed, 2 insertions(+)
--- a/drivers/staging/panel/panel.c +++ b/drivers/staging/panel/panel.c @@ -2179,6 +2179,7 @@ int panel_init(void) if (pprt) { parport_release(pprt); parport_unregister_device(pprt); + pprt = NULL; } parport_unregister_driver(&panel_driver); printk(KERN_ERR "Panel driver version " PANEL_VERSION @@ -2228,6 +2229,7 @@ static void __exit panel_cleanup_module( /* TODO: free all input signals */ parport_release(pprt); parport_unregister_device(pprt); + pprt = NULL; } parport_unregister_driver(&panel_driver); }
| |