Messages in this thread | | | Subject | Re: [PATCH] DRM: Replace kmalloc/memset combos with kzalloc | From | Davidlohr Bueso <> | Date | Wed, 11 Aug 2010 15:58:43 -0400 |
| |
On Wed, 2010-08-11 at 07:35 -0700, Joe Perches wrote: > On Wed, 2010-08-11 at 09:18 -0400, Davidlohr Bueso wrote: > > memory allocation in drm_bufs.c is followed by initializing the memory with 0. > > > > Replace the use of kmalloc+memset with kzalloc. > > Perhaps kzalloc's with a multiply could/should also be converted > to kcalloc. > > > + entry->buflist = kzalloc(count * sizeof(*entry->buflist), GFP_KERNEL); > > entry->buflist = kcalloc(count, sizeof(*entry->buflist), GFP_KERNEL); > > etc. > > > + entry->buflist = kzalloc(count * sizeof(*entry->buflist), GFP_KERNEL); > > + entry->seglist = kzalloc(count * sizeof(*entry->seglist), GFP_KERNEL); > > + entry->buflist = kzalloc(count * sizeof(*entry->buflist), > > + entry->buflist = kzalloc(count * sizeof(*entry->buflist), >
Doable, but don't see much difference. David, what do you think?
Thanks, Davidlohr
| |