Messages in this thread | | | From | "Masayuki Ohtake" <> | Subject | Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to 2.6.35 | Date | Wed, 11 Aug 2010 15:31:26 +0900 |
| |
Hi Balbi
I can do well.
Thanks! Ohtake.
----- Original Message ----- From: "Felipe Balbi" <felipe.balbi@nokia.com> To: "ext Masayuki Ohtake" <masa-korg@dsn.okisemi.com> Cc: "Greg KH" <gregkh@suse.de>; "Wang, Qi" <qi.wang@intel.com>; <arjan@linux.intel.com>; "Khor, Andrew Chih Howe" <andrew.chih.howe.khor@intel.com>; "Wang, Yong Y" <yong.y.wang@intel.com>; "LKML" <linux-kernel@vger.kernel.org>; <meego-dev@meego.com> Sent: Wednesday, August 11, 2010 2:49 PM Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to 2.6.35
> On Wed, Aug 11, 2010 at 04:14:51AM +0200, ext Masayuki Ohtake wrote: > >> > > +#define TRUE 1 > >> > > +#define FALSE 0 > >> > > >> > These lines should not be needed at all. > >> OKI-san, please remove them, Those definition is useless. > > > >Is the above definition is necessary? > >I can't find appropriate header file defines 'TRUE' and 'FALSE'. > > it's true and false. Lowercase. UNUSED is __unused. > > -- > balbi > > DefectiveByDesign.org >
| |