Messages in this thread | | | From | "Masayuki Ohtake" <> | Subject | Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to 2.6.35 | Date | Wed, 11 Aug 2010 15:30:20 +0900 |
| |
Hi Greg,
> Use the 'bool' type, and 'true' and/or 'false' keywords instead. That > is the proper C idiom. I can do well.
Thanks, Ohtake.
----- Original Message ----- From: "Greg KH" <gregkh@suse.de> To: "Masayuki Ohtake" <masa-korg@dsn.okisemi.com> Cc: "Wang, Qi" <qi.wang@intel.com>; <meego-dev@meego.com>; "LKML" <linux-kernel@vger.kernel.org>; "Wang, Yong Y" <yong.y.wang@intel.com>; "Khor, Andrew Chih Howe" <andrew.chih.howe.khor@intel.com>; <arjan@linux.intel.com> Sent: Wednesday, August 11, 2010 1:39 PM Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to 2.6.35
> On Wed, Aug 11, 2010 at 01:34:33PM +0900, Masayuki Ohtake wrote: > > Hi Qi-san > > > > I have found Macro 'TRUE' and 'FALSE' are used as setting value in the driver; still, > > can't I use TRUE/FALSE macro ? > > If not, How should we implement ? > > Use the 'bool' type, and 'true' and/or 'false' keywords instead. That > is the proper C idiom. > > thanks, > > greg k-h >
| |