lkml.org 
[lkml]   [2010]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] mfd: tps6586x depends on GPIOLIB
On Tue, Aug 10, 2010 at 09:40:59AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> tps6586x uses gpio interfaces, so it should depend on GPIOLIB.
Thanks Randy, I merged this one into the yet to be pulled tps6586x driver.

Cheers,
Samuel.

> Fixes these build errors:
>
> drivers/mfd/tps6586x.c:41: error: field 'gpio' has incomplete type
> drivers/mfd/tps6586x.c:195: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/mfd/tps6586x.c:195: warning: initialization from incompatible pointer type
> drivers/mfd/tps6586x.c:210: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/mfd/tps6586x.c:210: warning: initialization from incompatible pointer type
> drivers/mfd/tps6586x.c:219: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/mfd/tps6586x.c:219: warning: initialization from incompatible pointer type
> drivers/mfd/tps6586x.c:249: error: implicit declaration of function 'gpiochip_add'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20100810.orig/drivers/mfd/Kconfig
> +++ linux-next-20100810/drivers/mfd/Kconfig
> @@ -543,7 +543,7 @@ config MFD_JZ4740_ADC
>
> config MFD_TPS6586X
> tristate "TPS6586x Power Management chips"
> - depends on I2C
> + depends on I2C && GPIOLIB
> select MFD_CORE
> help
> If you say yes here you get support for the TPS6586X series of

--
Intel Open Source Technology Centre
http://oss.intel.com/


\
 
 \ /
  Last update: 2010-08-11 01:17    [W:1.985 / U:1.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site