lkml.org 
[lkml]   [2010]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 60/68] mxser: remove unnesesary NULL check
    Date
    From: Kulikov Vasiliy <segooon@gmail.com>

    mxser_transmit_chars(tty, port) is called only from mxser_interrupt().
    NULL check is performed in mxser_interrupt() so it is redundant here.

    Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
    Acked-by: Jiri Slaby <jirislaby@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/char/mxser.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)
    diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
    index d2692d4..3fc89da 100644
    --- a/drivers/char/mxser.c
    +++ b/drivers/char/mxser.c
    @@ -2193,7 +2193,7 @@ static void mxser_transmit_chars(struct tty_struct *tty, struct mxser_port *port
    port->mon_data.up_txcnt += (cnt - port->xmit_cnt);
    port->icount.tx += (cnt - port->xmit_cnt);

    - if (port->xmit_cnt < WAKEUP_CHARS && tty)
    + if (port->xmit_cnt < WAKEUP_CHARS)
    tty_wakeup(tty);

    if (port->xmit_cnt <= 0) {
    --
    1.7.2


    \
     
     \ /
      Last update: 2010-08-11 00:07    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean