lkml.org 
[lkml]   [2010]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subjectasm/vga.h (was: Re: drm: Add support for platform devices to register as DRM devices)
    From
    On Fri, Aug 6, 2010 at 01:59, Linux Kernel Mailing List
    <linux-kernel@vger.kernel.org> wrote:
    > Gitweb:     http://git.kernel.org/linus/dcdb167402cbdca1d021bdfa5f63995ee0a79317
    > Commit:     dcdb167402cbdca1d021bdfa5f63995ee0a79317
    > Parent:     01d73a6967f12fe6c4bbde1834a9fe662264a2eb
    > Author:     Jordan Crouse <jcrouse@codeaurora.org>
    > AuthorDate: Thu May 27 13:40:25 2010 -0600
    > Committer:  Dave Airlie <airlied@redhat.com>
    > CommitDate: Tue Jun 1 10:07:39 2010 +1000
    >
    >    drm: Add support for platform devices to register as DRM devices

    > --- a/drivers/gpu/drm/Kconfig
    > +++ b/drivers/gpu/drm/Kconfig
    > @@ -6,7 +6,7 @@
    >  #
    >  menuconfig DRM
    >        tristate "Direct Rendering Manager (XFree86 4.1.0 and higher DRI support)"
    > -       depends on (AGP || AGP=n) && PCI && !EMULATED_CMPXCHG && MMU
    > +       depends on (AGP || AGP=n) && !EMULATED_CMPXCHG && MMU

    Since this change, I can enable DRM on m68k, but it fails with:

    | In file included from drivers/gpu/drm/drm_irq.c:42:
    | include/linux/vgaarb.h:34:21: error: asm/vga.h: No such file or directory

    Now, do we really need <asm/vga.h>? It seems I can make it build and boot using:

    --- a/include/linux/vgaarb.h
    +++ b/include/linux/vgaarb.h
    @@ -31,7 +31,9 @@
    #ifndef LINUX_VGA_H
    #define LINUX_VGA_H

    +#ifdef CONFIG_VGA_ARB
    #include <asm/vga.h>
    +#endif

    /* Legacy VGA regions */
    #define VGA_RSRC_NONE 0x00
    Alternatively, I can provide an empty <asm/vga.h> (cfr. frv, mn10300,
    parisc, sh)
    or a simple (probably incorrect) one that includes <asm-generic/vga.h>
    (cfr. microblaze).
    But so far we never needed <asm/vga.h> on m68k.

    For the record, this "problem" has been visible in linux-next (see
    m68k/allmodconfig)
    since July 9...

    Gr{oetje,eeting}s,
                            Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
                                    -- Linus Torvalds
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-08-10 22:37    [W:0.022 / U:2.004 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site