Messages in this thread | | | Date | Tue, 10 Aug 2010 18:32:11 +0300 | From | Mike Rapoport <> | Subject | Re: [PATCH] regulator: tps6586x - add regulator_unregister() in tps6586x_regulator_remove() |
| |
Mark Brown wrote: > On Mon, Aug 09, 2010 at 03:58:06PM +0800, Axel Lin wrote: >> Signed-off-by: Axel Lin <axel.lin@gmail.com> > > Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Mike Rapoport <mike@compulab.co.il>
> >> >> - platform_set_drvdata(pdev, ri); >> + platform_set_drvdata(pdev, rdev); >> > > This would've been easier to review if you'd mentioned in the changelog > that there were no users of the current platform data, just to show that > you'd checked.
-- Sincerely yours, Mike.
| |