Messages in this thread | | | Subject | Re: [PATCHv4] fixed resource leak in scripts/mod/modpost.c | From | Alexey Fomenko <> | Date | Tue, 10 Aug 2010 15:40:28 +0300 |
| |
On Tue, 2010-08-10 at 14:21 +0200, ext Andy Shevchenko wrote: > On Tue, Aug 10, 2010 at 3:03 PM, Alexey Fomenko > <ext-alexey.fomenko@nokia.com> wrote: > > From: Alexey Fomenko <ext-alexey.fomenko@nokia.com> > > > > sec2annotation() returns malloc'ed buffer directly to printf as an > > argument. Patch lets free this buffer after printing. Preventing ops > > while freeing the buffer by changing return const str to return > > strdup empty line. > > > > Signed-off-by: Alexey Fomenko <ext-alexey.fomenko@nokia.com> > > > @@ -1283,11 +1301,15 @@ > > "uses functionality in the exit path.\n" > > "The fix is often to remove the %sannotation of\n" > > "%s%s so it may be used outside an exit section.\n", > > - from, sec2annotation(fromsec), fromsym, from_p, > > - to, sec2annotation(tosec), tosym, to_p, > > - sec2annotation(tosec), tosym, to_p); > > + from, prl_from, fromsym, from_p, > > + to, prl_to, tosym, to_p, > > + ptl_to, tosym, to_p); > Did you ever compile this code? > It looks typo here. Ever - yes, last one - no, was in a hurry. Shouldn't have been. I'll fix it.
> > > + free(prl_from); > > + free(prl_to); > > break; > > case ANY_EXIT_TO_ANY_INIT: > > + prl_from = sec2annotation(fromsec); > > + prl_to = sec2annotation(tosec); > > fprintf(stderr, > > "The %s %s%s%s references\n" > > "a %s %s%s%s.\n" >
| |