Messages in this thread |  | | | Date | Sun, 01 Aug 2010 14:06:38 +0400 | | From | Sergei Shtylyov <> | | Subject | Re: [PATCH 5/7] usb: omap_udc: check return value of proc_create() |
| |
Hello.
Kulikov Vasiliy wrote:
> proc_create() may fail, if so return -ENOMEM.
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> [...] > diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c > index f81e4f0..1083216 100644 > --- a/drivers/usb/gadget/omap_udc.c > +++ b/drivers/usb/gadget/omap_udc.c > @@ -2544,9 +2544,9 @@ static const struct file_operations proc_ops = { > .release = single_release, > }; > > -static void create_proc_file(void) > +static int create_proc_file(void) > { > - proc_create(proc_filename, 0, NULL, &proc_ops); > + return (proc_create(proc_filename, 0, NULL, &proc_ops) == NULL);
Parens not needed around the *return* expression.
WBR, Sergei
|  |