lkml.org 
[lkml]   [2010]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv10 2.6.35-rc6-tip 9/14] trace: uprobes trace_event interface
Frederic Weisbecker wrote:
> On Thu, Jul 29, 2010 at 02:04:14PM +0900, Masami Hiramatsu wrote:
>> Srikar Dronamraju wrote:
>>> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
>>> index c681fa7..16e2a8c 100644
>>> --- a/kernel/trace/Kconfig
>>> +++ b/kernel/trace/Kconfig
>>> @@ -482,6 +482,22 @@ config RING_BUFFER_BENCHMARK
>>>
>>> If unsure, say N.
>>>
>>> +config UPROBE_EVENT
>>> + bool "Enable uprobes-based dynamic events"
>>> + depends on ARCH_SUPPORTS_UPROBES
>>> + depends on MMU
>>> + select UPROBES
>>> + select PROBE_EVENTS
>>> + select TRACING
>>> + default n
>>> + help
>>> + This allows the user to add tracing events on top of userspace dynamic
>>> + events (similar to tracepoints) on the fly via the traceevents interface.
>>> + Those events can be inserted wherever uprobes can probe, and record
>>> + various registers.
>>> + This option is required if you plan to use perf-probe subcommand of perf
>>> + tools on user space applications.
>>> +
>> Possible enhancement: Moving this config right after KPROBE_EVENT, because
>> those two provide similar dynamic events.
>>
>> Thank you,
>
>
> In fact this could be a menu "Dynamic Probes", perhaps default off, inside
> which Kprobes and Uprobes would be default on (but depend on "Dynamic Probes").
>
> So that you can quickly enable them all in one.

Hmm, I disagree with it, because both Kprobes and Uprobes provides
APIs for modules too.

I'd like to suggest below config tree

Kenrel hacking
- Kprobes
- Uprobes
- Tracing
-- Dynamic Events
depends on Kprobes || Uprobes
or
select Kprobes && Uprobes
Thank you,

--
Masami HIRAMATSU
2nd Research Dept.
Hitachi, Ltd., Systems Development Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com


\
 
 \ /
  Last update: 2010-08-02 05:47    [from the cache]
©2003-2011 Jasper Spaans