lkml.org 
[lkml]   [2010]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] vmscan: stop meaningless loop iteration when no reclaimable slab
    Date
    If number of reclaimable slabs are zero, shrink_icache_memory() and
    shrink_dcache_memory() return 0. but strangely shrink_slab() ignore
    it and continue meaningless loop iteration.

    This patch fixes it.

    Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    ---
    mm/vmscan.c | 5 +++++
    1 files changed, 5 insertions(+), 0 deletions(-)

    diff --git a/mm/vmscan.c b/mm/vmscan.c
    index 0f9f624..8f61adb 100644
    --- a/mm/vmscan.c
    +++ b/mm/vmscan.c
    @@ -243,6 +243,11 @@ unsigned long shrink_slab(unsigned long scanned, gfp_t gfp_mask,
    int nr_before;

    nr_before = (*shrinker->shrink)(0, gfp_mask);
    + /* no slab objects, no more reclaim. */
    + if (nr_before == 0) {
    + total_scan = 0;
    + break;
    + }
    shrink_ret = (*shrinker->shrink)(this_scan, gfp_mask);
    if (shrink_ret == -1)
    break;
    --
    1.6.5.2




    \
     
     \ /
      Last update: 2010-07-09 12:17    [W:5.676 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site