Messages in this thread | | | Subject | Re: [PATCH 1/1] Bluetooth: hidp: Add support for hidraw HIDIOCGFEATURE and HIDIOCSFEATURE | From | Marcel Holtmann <> | Date | Fri, 09 Jul 2010 05:01:37 -0300 |
| |
Hi Alan,
> > I looked at this and I am bit worried that this should not be done in > > this detail in the HIDP driver. Essentially HIDP is a pure transport > > driver. It should not handle all these details. Can we make this a bit > > easier for the transport drivers to support such features? > > I put these changes (most notably the addition of hidp_get_raw_report()) > in hidp because that's where the parallel function > hidp_output_raw_report() was already located. I figured the input should > go with the output. That said, if there's a better place for both of > them (input and output) to go, let me know where you think it should be, > and I'll get them moved into the proper spot. > > I'm not sure what you mean about HIDP being a pure transport driver.
what is usb-hid.ko doing here? I would expect a bunch of code duplication with minor difference between USB and Bluetooth.
Regards
Marcel
| |