Messages in this thread | | | Date | Fri, 9 Jul 2010 14:25:57 -0700 | Subject | Re: [PATCH][GIT PULL][for 2.6.35] tracing: Add alignment to syscall metadata declarations | From | Linus Torvalds <> |
| |
On Fri, Jul 9, 2010 at 1:33 PM, Sam Ravnborg <sam@ravnborg.org> wrote: > > Something like this: > (whitespace damaged) > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h > index 48c5299..64430d3 100644 > --- a/include/asm-generic/vmlinux.lds.h > +++ b/include/asm-generic/vmlinux.lds.h > @@ -133,7 +133,8 @@ > #endif > > #ifdef CONFIG_FTRACE_SYSCALLS > -#define TRACE_SYSCALLS() VMLINUX_SYMBOL(__start_syscalls_metadata) = .; \ > +#define TRACE_SYSCALLS() . = ALIGN(8); \ > + VMLINUX_SYMBOL(__start_syscalls_metadata) = .; \ > *(__syscalls_metadata) \ > VMLINUX_SYMBOL(__stop_syscalls_metadata) = .; > #else
If this is confirmed to fix it, then I would much prefer this version.
That said, I do wonder whether we shouldn't do the ALIGN(8) in the DATA_DATA define instead. That's what we do for other things like this (start_markers, start__verbose, etc etc)
Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |