lkml.org 
[lkml]   [2010]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] ocfs2: When zero extending, do it by page.
    On Thu, Jul 08, 2010 at 11:44:59AM +0800, Tao Ma wrote:
    > On 07/07/2010 07:16 PM, Joel Becker wrote:
    > >+ BUG_ON(abs_to> ((index + 1)<< PAGE_CACHE_SHIFT));
    > Sorry for not noticing this yesterday night. This can't work and
    > will overflow and bug out. I met with a similar bug in reflink test.
    > See commit d622b89.

    Good catch. It's obvious, now that you mention it.

    > >+ /* We know that zero_from is block aligned */
    > >+ for (block_start = zero_from;
    > >+ (block_start< PAGE_CACHE_SIZE)&& (block_start< zero_to);
    > >+ block_start = block_end) {
    > Do we really need to check block_start < PAGE_CACHE_SIZE? I think
    > just check block_start < zero_to is enough since you have limit
    > zero_to with PAGE_CACHE_SIZE. What's more, it looks more natural(see
    > below), does it?
    >
    > for (block_start = zero_form; block_start < zero_to; block_start =
    > block_end) {

    Yup. The code looked different halfway through, so I didn't
    realize I was checking the same thing twice.

    Joel

    --

    "Depend on the rabbit's foot if you will, but remember, it didn't
    help the rabbit."
    - R. E. Shay

    Joel Becker
    Consulting Software Developer
    Oracle
    E-mail: joel.becker@oracle.com
    Phone: (650) 506-8127


    \
     
     \ /
      Last update: 2010-07-08 11:55    [W:5.558 / U:0.388 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site