Messages in this thread |  | | | Date | Thu, 8 Jul 2010 16:01:48 -0500 (CDT) | | From | Christoph Lameter <> | | Subject | Re: [PATCH v2 2/2] vmscan: shrink_slab() require number of lru_pages, not page order |
| |
On Thu, 8 Jul 2010, Andrew Morton wrote:
> > AFAICT this is not argument error but someone changed the naming of the > > parameter. > > It's been there since day zero: > > : commit 2a16e3f4b0c408b9e50297d2ec27e295d490267a > : Author: Christoph Lameter <clameter@engr.sgi.com> > : AuthorDate: Wed Feb 1 03:05:35 2006 -0800 > : Commit: Linus Torvalds <torvalds@g5.osdl.org> > : CommitDate: Wed Feb 1 08:53:16 2006 -0800 > : > : [PATCH] Reclaim slab during zone reclaim
That only shows that the order parameter was passed to shrink_slab() which is what I remember being done intentionally.
Vaguely recall that this was necessary to avoid shrink_slab() throwing out too many pages for higher order allocs.
Initially zone_reclaim was full of heuristics that later were replaced by counter as the new ZVCs became available and gradually better ways of accounting for pages became possible.
|  |