lkml.org 
[lkml]   [2010]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 2/2] vmscan: shrink_slab() require number of lru_pages, not page order
    On Thu, 8 Jul 2010, Andrew Morton wrote:

    > > AFAICT this is not argument error but someone changed the naming of the
    > > parameter.
    >
    > It's been there since day zero:
    >
    > : commit 2a16e3f4b0c408b9e50297d2ec27e295d490267a
    > : Author: Christoph Lameter <clameter@engr.sgi.com>
    > : AuthorDate: Wed Feb 1 03:05:35 2006 -0800
    > : Commit: Linus Torvalds <torvalds@g5.osdl.org>
    > : CommitDate: Wed Feb 1 08:53:16 2006 -0800
    > :
    > : [PATCH] Reclaim slab during zone reclaim

    That only shows that the order parameter was passed to shrink_slab() which
    is what I remember being done intentionally.

    Vaguely recall that this was necessary to avoid shrink_slab() throwing out
    too many pages for higher order allocs.

    Initially zone_reclaim was full of heuristics that later were replaced by
    counter as the new ZVCs became available and gradually better ways of
    accounting for pages became possible.





    \
     
     \ /
      Last update: 2010-07-08 23:05    [W:0.043 / U:61.468 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site