Messages in this thread | | | Subject | Re: [PATCH v2 17/26] MTD: Nand: Add JZ4740 NAND driver | From | Artem Bityutskiy <> | Date | Thu, 08 Jul 2010 09:06:54 +0300 |
| |
On Sat, 2010-06-19 at 07:08 +0200, Lars-Peter Clausen wrote: > diff --git a/include/linux/mtd/jz4740_nand.h b/include/linux/mtd/jz4740_nand.h > new file mode 100644 > index 0000000..379f9b6 > --- /dev/null > +++ b/include/linux/mtd/jz4740_nand.h > @@ -0,0 +1,34 @@ > +/* > + * Copyright (C) 2009-2010, Lars-Peter Clausen <lars@metafoo.de> > + * JZ4740 SoC NAND controller driver > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2 of the License, or (at your > + * option) any later version. > + * > + * You should have received a copy of the GNU General Public License along > + * with this program; if not, write to the Free Software Foundation, Inc., > + * 675 Mass Ave, Cambridge, MA 02139, USA. > + * > + */ > + > +#ifndef __JZ_NAND_H__ > +#define __JZ_NAND_H__ > + > +#include <linux/mtd/nand.h> > +#include <linux/mtd/partitions.h> > + > +struct jz_nand_platform_data { > + int num_partitions; > + struct mtd_partition *partitions; > + > + struct nand_ecclayout *ecc_layout; > + > + unsigned int busy_gpio; > + > + void (*ident_callback)(struct platform_device *, struct nand_chip *, > + struct mtd_partition **, int *num_partitions); > +}; > + > +#endif
Do you really have to add your platform data strucutre to "inlculde/mtd" ? That is quite global namespace, and ideally only things like user-space interface and "public" interface of the MTD subsystem should live there.
Can you keep this somewhere in mips architecture directory? -- Best Regards, Artem Bityutskiy (Артём Битюцкий)
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |