lkml.org 
[lkml]   [2010]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: gadget: #include device.h in gadget.h
Hello.

Patrick Pannuto wrote:

> gadget.h uses structures defined in device.h, it must include it. In
> most cases, gadget.h is preceded by linux/platform_device.h, but if
> you are grouping headers sanely, device.h may not be pulled in until
> *after* gadget (e.g. mach/msm_device.h), thus gadget.h should not
> rely on something else #including device.h

Sigh, I've already submitted a more complete patch, adding 6 #include's
but it seems that prevailing opinion in this list is to leave things as they
are in the header, and deal with the fallout wherever it's used.

[...]

> diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
> index bbf45d5..ddca035 100644
> --- a/include/linux/usb/gadget.h
> +++ b/include/linux/usb/gadget.h
> @@ -15,6 +15,8 @@
> #ifndef __LINUX_USB_GADGET_H
> #define __LINUX_USB_GADGET_H
>
> +#include <linux/device.h>
> +

Besides, this is not against the recent kernel -- there should be #include
<linux/slab.h> here.

> struct usb_ep;
>
> /**

WBR, Sergei


\
 
 \ /
  Last update: 2010-07-08 21:15    [W:0.054 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site