lkml.org 
[lkml]   [2010]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
FromBjorn Helgaas <>
SubjectRe: [PATCH 03/23] lmb: Print new doubled array location info
DateThu, 8 Jul 2010 12:55:56 -0600
On Sunday, July 04, 2010 12:56:07 am Yinghai Lu wrote:
> - pr_info(" %s[0x%x]\t0x%016llx - 0x%016llx, 0x%llx bytes\n",
> - name, i, base, base + size - 1, size);
> + pr_info(" %s[%#x]\t[%#016llx - %#016llx], %#llx bytes\n",
> + name, i, base, base + size, size);

I know you think it's prettier to have zeroes and extra spaces like this:

[0xe7000000 - 0xe8000000, 0x1000000 bytes]
rather than a bunch of 'F's:

[0xe7000000-0xe7ffffff]
But for the record, I still think you're wrong and that it's better
to be consistent even if it's slightly uglier. The inconsistencies
lead to confusion and off-by-one errors.

Bjorn


\
 
 \ /
  Last update: 2010-07-08 20:59    [from the cache]
©2003-2010