Messages in this thread | | | Subject | Re: [PATCH v4 08/12] Inject asynchronous page fault into a guest if page is swapped out. | From | Peter Zijlstra <> | Date | Thu, 08 Jul 2010 20:09:21 +0200 |
| |
On Thu, 2010-07-08 at 21:05 +0300, Gleb Natapov wrote: > > > + /* do alloc atomic since if we are going to sleep anyway we > > > + may as well sleep faulting in page */ > > > + work = kmem_cache_zalloc(async_pf_cache, GFP_ATOMIC); > > > + if (!work) > > > + return 0; > > > > GFP_KERNEL is fine for this context. > But it can sleep, no? The comment explains why I don't want to sleep > here.
In that case, use 0, no use wasting __GFP_HIGH on something that doesn't actually need it.
| |