lkml.org 
[lkml]   [2010]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 06/18] spufs: use llseek in all file operations
    From
    Date
    Hi Arnd,

    > The default for llseek is changing, so we need
    > explicit operations everywhere.

    Looks good, but:

    > @@ -2151,7 +2166,7 @@ static ssize_t spufs_ibox_info_read(struct file *file, char __user *buf,
    > static const struct file_operations spufs_ibox_info_fops = {
    > .open = spufs_info_open,
    > .read = spufs_ibox_info_read,
    > - .llseek = generic_file_llseek,
    > + .llseek = no_llseek,
    > };
    >
    > static ssize_t __spufs_wbox_info_read(struct spu_context *ctx,
    > @@ -2194,7 +2209,7 @@ static ssize_t spufs_wbox_info_read(struct file *file, char __user *buf,
    > static const struct file_operations spufs_wbox_info_fops = {
    > .open = spufs_info_open,
    > .read = spufs_wbox_info_read,
    > - .llseek = generic_file_llseek,
    > + .llseek = no_llseek,
    > };
    >

    Why the change in behaviour for the mbox info files?

    Cheers,


    Jeremy



    \
     
     \ /
      Last update: 2010-07-08 03:17    [W:0.042 / U:180.276 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site