lkml.org 
[lkml]   [2010]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/18] lkdtm: use generic_file_llseek in debugfs
    Date
    When the default llseek behavior gets changed to
    not allowing seek, all file operations that rely
    on the current behaviour need to use an explicit
    .llseek operation.

    The files that lkdtm uses in debugfs are regular
    files and they get read using simple_read_from_buffer,
    so generic_file_llseek is the right operation.

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    ---
    drivers/misc/lkdtm.c | 9 +++++++++
    1 files changed, 9 insertions(+), 0 deletions(-)

    diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c
    index 5bfb2a2..7d7ce0e 100644
    --- a/drivers/misc/lkdtm.c
    +++ b/drivers/misc/lkdtm.c
    @@ -575,30 +575,39 @@ struct crash_entry {

    static const struct crash_entry crash_entries[] = {
    {"DIRECT", {.read = lkdtm_debugfs_read,
    + .llseek = generic_file_llseek,
    .open = lkdtm_debugfs_open,
    .write = direct_entry} },
    {"INT_HARDWARE_ENTRY", {.read = lkdtm_debugfs_read,
    + .llseek = generic_file_llseek,
    .open = lkdtm_debugfs_open,
    .write = int_hardware_entry} },
    {"INT_HW_IRQ_EN", {.read = lkdtm_debugfs_read,
    + .llseek = generic_file_llseek,
    .open = lkdtm_debugfs_open,
    .write = int_hw_irq_en} },
    {"INT_TASKLET_ENTRY", {.read = lkdtm_debugfs_read,
    + .llseek = generic_file_llseek,
    .open = lkdtm_debugfs_open,
    .write = int_tasklet_entry} },
    {"FS_DEVRW", {.read = lkdtm_debugfs_read,
    + .llseek = generic_file_llseek,
    .open = lkdtm_debugfs_open,
    .write = fs_devrw_entry} },
    {"MEM_SWAPOUT", {.read = lkdtm_debugfs_read,
    + .llseek = generic_file_llseek,
    .open = lkdtm_debugfs_open,
    .write = mem_swapout_entry} },
    {"TIMERADD", {.read = lkdtm_debugfs_read,
    + .llseek = generic_file_llseek,
    .open = lkdtm_debugfs_open,
    .write = timeradd_entry} },
    {"SCSI_DISPATCH_CMD", {.read = lkdtm_debugfs_read,
    + .llseek = generic_file_llseek,
    .open = lkdtm_debugfs_open,
    .write = scsi_dispatch_cmd_entry} },
    {"IDE_CORE_CP", {.read = lkdtm_debugfs_read,
    + .llseek = generic_file_llseek,
    .open = lkdtm_debugfs_open,
    .write = ide_core_cp_entry} },
    };
    --
    1.7.1


    \
     
     \ /
      Last update: 2010-07-07 23:43    [W:0.029 / U:2.552 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site