Messages in this thread |  | | | Date | Thu, 8 Jul 2010 01:23:03 +1000 | | From | Nick Piggin <> | | Subject | Re: [PATCH -V14 04/11] vfs: Allow handle based open on symlinks |
| |
On Tue, Jun 15, 2010 at 10:42:54PM +0530, Aneesh Kumar K.V wrote: > The patch update may_open to allow handle based open on symlinks. > The file handle based API use file descritor returned from open_by_handle_at > to do different file system operations. To find the link target name we > need to get a file descriptor on symlinks.
This is a pretty big change, isn't it? Have you looked through vfs to ensure this is actually OK? I was just looking at remount,ro code, for example, and it seems to assume only writable open files on ISREG files.
Is this restricted to RDONLY? Really, it should be O_NONE...
|  |