lkml.org 
[lkml]   [2010]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 8/9] KVM: MMU: combine guest pte read between fetch and pte prefetch
On Wed, Jul 07, 2010 at 09:11:56PM +0800, Xiao Guangrong wrote:
>
>
> Marcelo Tosatti wrote:
>
> >>
> >> Below codes read gptes in the prefetch path:
> >>
> >> index = sptep - sp->spt;
> >> i = index & ~(PTE_PREFETCH_NUM - 1);
> >> max = index | (PTE_PREFETCH_NUM - 1);
> >>
> >> if (PTTYPE == 32)
> >> offset = sp->role.quadrant << PT64_LEVEL_BITS;
> >>
> >> first_pte_gpa = gfn_to_gpa(sp->gfn) +
> >> (offset + i) * sizeof(pt_element_t);
> >>
> >> if (kvm_read_guest_atomic(vcpu->kvm, first_pte_gpa, gptep,
> >> sizeof(gptep)) < 0)
> >> return;
> >>
> >> It reads the 16 aligned items around sptep's corresponding gpte and this gpte
> >> is also in this area. :-)
> >
> > But you removed that in patch 8?
> >
>
> Oh, i just want it good for review, you mean it's better let patch 7 and 8 in one patch?

I mean patch 7 is wrong because it removes rereading of gpte, with
mmu_lock held, in the prefetch patch.


\
 
 \ /
  Last update: 2010-07-07 15:55    [W:0.051 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site