lkml.org 
[lkml]   [2010]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 12/14] vmscan: Do not writeback pages in direct reclaim
    On Tue, Jul 06, 2010 at 09:36:41AM +0900, KOSAKI Motohiro wrote:
    > Hello,
    >
    > > Ok, that's reasonable as I'm still working on that patch. For example, the
    > > patch disabled anonymous page writeback which is unnecessary as the stack
    > > usage for anon writeback is less than file writeback.
    >
    > How do we examine swap-on-file?
    >

    Anything in particular wrong with the following?

    /*
    * For now, only kswapd can writeback filesystem pages as otherwise
    * there is a stack overflow risk
    */
    static inline bool reclaim_can_writeback(struct scan_control *sc,
    struct page *page)
    {
    return !page_is_file_cache(page) || current_is_kswapd();
    }

    Even if it is a swapfile, I didn't spot a case where the filesystems
    writepage would be called. Did I miss something?

    --
    Mel Gorman
    Part-time Phd Student Linux Technology Center
    University of Limerick IBM Dublin Software Lab


    \
     
     \ /
      Last update: 2010-07-06 12:15    [W:0.022 / U:29.820 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site