lkml.org 
[lkml]   [2010]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] hp-wmi: add return value checking for input_allocate_device()
    Date
    Hi,

    it's incredible how much cleanups and fixes you find in this
    handful of drivers... It's very much appreciated!

    On Tuesday 06 July 2010 04:30:26 Axel Lin wrote:
    > Add error checking and return -ENOMEM if input_allocate_device() fail.
    >
    > Signed-off-by: Axel Lin <axel.lin@gmail.com>
    > ---
    > drivers/platform/x86/hp-wmi.c | 2 ++
    > 1 files changed, 2 insertions(+), 0 deletions(-)
    >
    > diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
    > index 51c07a0..c508e20 100644
    > --- a/drivers/platform/x86/hp-wmi.c
    > +++ b/drivers/platform/x86/hp-wmi.c
    > @@ -402,6 +402,8 @@ static int __init hp_wmi_input_setup(void)
    > int err;
    >
    > hp_wmi_input_dev = input_allocate_device();
    > + if (!hp_wmi_input_dev)
    > + return -ENOMEM;
    >
    > hp_wmi_input_dev->name = "HP WMI hotkeys";
    > hp_wmi_input_dev->phys = "wmi/input0";
    But also hp_wmi_input_setup() call should get checked and if it
    fails, the previous wmi_install_notify_handler() must get uninstalled
    again. Hm, probably the whole driver shouldn't load then and
    the error code from hp_wmi_input_setup() can be returned in
    hp_wmi_init(void).

    Do you mind to incorporate above if you agree.

    Thanks,

    Thomas


    \
     
     \ /
      Last update: 2010-07-06 09:59    [W:0.020 / U:180.284 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site