Messages in this thread | | | Date | Tue, 6 Jul 2010 09:21:09 +0200 | From | Jean Delvare <> | Subject | Re: [PATCH/RFC v2 4/4] hwmon: sysfs API updates |
| |
On Mon, 5 Jul 2010 14:39:53 -0700, Guenter Roeck wrote: > Hi Jean, > > I noticed I did not copy the list with my reply, so here are are again, > with a couple of additional comments. > > On Mon, Jul 05, 2010 at 03:18:57AM -0400, Jean Delvare wrote: > > On Sun, 4 Jul 2010 21:10:18 -0700, Guenter Roeck wrote: > > > @@ -482,10 +501,17 @@ OR > > > > > > in[0-*]_min_alarm > > > in[0-*]_max_alarm > > > +in[0-*]_lcrit_alarm > > > +in[0-*]_crit_alarm > > > +curr[1-*]_lcrit_alarm > > > +curr[1-*]_crit_alarm > > > > No _min and _max alarm for curr? > > > Oversight. pmbus devices don't support currX_min and currX_min_alarm, only > currX_lcrit and currX_lcrit_alarm. The ltc4245 driver already supports > currX_max_alarm, though, so I'll add both for consistency. > > The ltc4245 driver only supports currX_max_alarm, not currX_min_alarm, though. > Wonder if that should be changed to currX_alarm, to more closely follow the API. > Let me know and I'll submit a patch if needed.
Both should be defined and supported, and the driver author chooses what fits his/her chip best.
-- Jean Delvare
| |