lkml.org 
[lkml]   [2010]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 3/6] autofs/autofs4: move compat_ioctl handling into fs
    Date


    On 06/07/2010, at 7:35 PM, Arnd Bergmann <arnd@arndb.de> wrote:

    >
    > Well, the only use of the BKL in autofs4 is in the ioctl function. You
    > can probably replace that trivially with a global mutex, but from a quick
    > inspection, even that should not be needed: The only ioctl command in
    > autofs4 that does not already seem to have adequate locking is
    > autofs4_get_set_timeout, which is even easier to change and still harmless
    > if you don't do it at all.

    That's right of course.

    Even this shouldn't be a problem as it is called by a single instance, per autofs mount, of the daemon only. A fair amount of effort has gone into trying to make the autofs4 module independent of the BKL over time. However I would still rather not do the change concurrently with the ioctl changes.

    Ian
    >


    \
     
     \ /
      Last update: 2010-07-06 15:19    [W:0.019 / U:61.728 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site