lkml.org 
[lkml]   [2010]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/7] hugetlb: add missing unlock in avoidcopy path in hugetlb_cow()
    On Fri, Jul 02, 2010 at 10:31:43AM +0200, Andi Kleen wrote:
    > On Fri, Jul 02, 2010 at 02:47:20PM +0900, Naoya Horiguchi wrote:
    > > This patch fixes possible deadlock in hugepage lock_page()
    > > by adding missing unlock_page().
    > >
    > > libhugetlbfs test will hit this bug when the next patch in this
    > > patchset ("hugetlb, HWPOISON: move PG_HWPoison bit check") is applied.
    >
    > This looks like a general bug fix that should be merged ASAP?
    >
    > Or do you think this cannot be hit at all without the other patches?

    This bug was introduced by patch "hugetlb, rmap: add reverse mapping for
    hugepage" in previous patchset (currently in linux-next) and it's not
    merged in mainline yet.
    So it's OK if this patch goes into linux-next by its merge to mainline.

    Thanks,
    Naoya Horiguchi


    \
     
     \ /
      Last update: 2010-07-05 10:53    [W:0.031 / U:60.500 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site