lkml.org 
[lkml]   [2010]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/9] Removing dead CONFIG_BLK_DEV_IDE
    On Wed, Jun 16, 2010 at 01:35:48PM +0200, Christoph Egger wrote:

    > On Thu, Jun 10, 2010 at 12:23:06PM -0600, Shane McDonald wrote:
    > > I wonder if, instead of deleting the code, the constant should be
    > > changed from CONFIG_BLK_DEV_IDE to CONFIG_IDE. The original
    > > patch that removed CONFIG_BLK_DEV_IDE seemed to make this change:
    > > http://kerneltrap.org/mailarchive/linux-kernel/2008/8/13/2929444
    > >
    > > Shane
    >
    > You're probably right, updated patch below
    >
    > -------
    > From: Christoph Egger <siccegge@cs.fau.de>
    > Date: Mon, 7 Jun 2010 17:29:48 +0200
    > Subject: [PATCH 5/9] Removing dead CONFIG_BLK_DEV_IDE
    >
    > CONFIG_BLK_DEV_IDE doesn't exist in Kconfig, therefore removing all
    > references for it from the source code.
    >
    > Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
    > ---
    > diff --git a/arch/mips/mti-malta/malta-setup.c
    > b/arch/mips/mti-malta/malta-setup.c
    > index b7f37d4..f6a5ea8 100644
    > --- a/arch/mips/mti-malta/malta-setup.c
    > +++ b/arch/mips/mti-malta/malta-setup.c
    > @@ -105,7 +105,7 @@ static void __init fd_activate(void)
    > }
    > #endif
    >
    > -#ifdef CONFIG_BLK_DEV_IDE
    > +#ifdef CONFIG_IDE

    This doesn't fly too well either. CONFIG_BLK_DEV_IDE was a bool but
    CONFIG_IDE is tristate. But changing the ifdef to

    #if defined(CONFIG_IDE) || defined(CONFIG_IDE_MODULE)

    wouldn't really work either. I think this needs some generic infrastructure
    to get the PCI clock.

    Or maybe this is just another reason to scrap IDE support.

    Ralf


    \
     
     \ /
      Last update: 2010-07-05 10:17    [W:0.022 / U:30.456 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site