Messages in this thread | | | Date | Mon, 05 Jul 2010 19:24:34 -0700 (PDT) | Subject | Re: [PATCH 2/2] isdn: avoid calling tty_ldisc_flush() in atomic context | From | David Miller <> |
| |
From: Tilman Schmidt <tilman@imap.cc> Date: Tue, 6 Jul 2010 02:18:27 +0200 (CEST)
> Remove the call to tty_ldisc_flush() from the RESULT_NO_CARRIER > branch of isdn_tty_modem_result(), as already proposed in commit > 00409bb045887ec5e7b9e351bc080c38ab6bfd33. > This avoids a "sleeping function called from invalid context" BUG > when the hardware driver calls the statcallb() callback with > command==ISDN_STAT_DHUP in atomic context, which in turn calls > isdn_tty_modem_result(RESULT_NO_CARRIER, ~), and from there, > tty_ldisc_flush() which may sleep. > > Impact: bugfix > Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Applied to net-next-2.6, thanks.
| |