Messages in this thread Patch in this message | | | From | Kulikov Vasiliy <> | Subject | [PATCH 2/7] usb: fsl_udc_core: check return value of create_proc_read_entry() | Date | Sat, 31 Jul 2010 21:38:20 +0400 |
| |
create_proc_read_entry() may fail, if so return -ENOMEM.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> --- drivers/usb/gadget/fsl_udc_core.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c index 08a9a62..c3d1545 100644 --- a/drivers/usb/gadget/fsl_udc_core.c +++ b/drivers/usb/gadget/fsl_udc_core.c @@ -2128,7 +2128,7 @@ static int fsl_proc_read(char *page, char **start, off_t off, int count, #else /* !CONFIG_USB_GADGET_DEBUG_FILES */ -#define create_proc_file() do {} while (0) +#define create_proc_file() ({ (void *)1; }) #define remove_proc_file() do {} while (0) #endif /* CONFIG_USB_GADGET_DEBUG_FILES */ @@ -2373,9 +2373,14 @@ static int __init fsl_udc_probe(struct platform_device *pdev) ret = -ENOMEM; goto err_unregister; } - create_proc_file(); + if (create_proc_file() == 0) { + ret = -ENOMEM; + goto err_pool; + } return 0; +err_pool: + dma_pool_destroy(udc_controller->td_pool); err_unregister: device_unregister(&udc_controller->gadget.dev); err_free_irq: -- 1.7.0.4
| |