Messages in this thread | | | Date | Fri, 30 Jul 2010 17:57:56 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH V3 2/5] Package Level Thermal Control and Power Limit Notification: pkgtemp hwmon driver |
| |
On 07/29/2010 05:13 PM, Fenghua Yu wrote: > + > +enum { SHOW_TEMP, SHOW_TJMAX, SHOW_TTARGET, SHOW_LABEL, SHOW_NAME } SHOW; > +
This conflicts with an equally poorly named global variable in drivers/hwmon/via-cputemp.c, and the conflict is causing a build failure.
I think both these drivers have the same bug: a missing "typedef" before the enum keyword, as present in coretemp.c. Of course, one can question if it should be given a typename at all since in none of these drivers they are actually referenced by type, and instead the enumeration is just used as a source of constants, which can perfectly well be handled with an unnamed enum:
enum { SHOW_TEMP, SHOW_TJMAX, SHOW_TTARGET, SHOW_LABEL, SHOW_NAME };
-hpa
| |