lkml.org 
[lkml]   [2010]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[192/205] ACPI / ACPICA: Fix sysfs GPE interface
    2.6.34-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Rafael J. Wysocki <rjw@sisk.pl>

    commit 9d3c752de65dbfa6e522f1d666deb0ac152ef367 upstream.

    The sysfs interface allowing user space to disable/enable GPEs
    doesn't work correctly, because a GPE disabled this way will be
    re-enabled shortly by acpi_ev_asynch_enable_gpe() if it was
    previosuly enabled by acpi_enable_gpe() (in which case the
    corresponding bit in its enable register's enable_for_run mask is
    set).

    To address this issue make the sysfs GPE interface use
    acpi_enable_gpe() and acpi_disable_gpe() instead of acpi_set_gpe()
    so that GPE reference counters are modified by it along with the
    values of GPE enable registers.

    Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
    Signed-off-by: Len Brown <len.brown@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/acpi/system.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    --- a/drivers/acpi/system.c
    +++ b/drivers/acpi/system.c
    @@ -389,10 +389,12 @@ static ssize_t counter_set(struct kobjec
    if (index < num_gpes) {
    if (!strcmp(buf, "disable\n") &&
    (status & ACPI_EVENT_FLAG_ENABLED))
    - result = acpi_set_gpe(handle, index, ACPI_GPE_DISABLE);
    + result = acpi_disable_gpe(handle, index,
    + ACPI_GPE_TYPE_RUNTIME);
    else if (!strcmp(buf, "enable\n") &&
    !(status & ACPI_EVENT_FLAG_ENABLED))
    - result = acpi_set_gpe(handle, index, ACPI_GPE_ENABLE);
    + result = acpi_enable_gpe(handle, index,
    + ACPI_GPE_TYPE_RUNTIME);
    else if (!strcmp(buf, "clear\n") &&
    (status & ACPI_EVENT_FLAG_SET))
    result = acpi_clear_gpe(handle, index, ACPI_NOT_ISR);



    \
     
     \ /
      Last update: 2010-07-30 20:09    [W:0.027 / U:150.068 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site