[lkml]   [2010]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[108/140] KVM: MMU: Remove user access when allowing kernel access to gpte.w=0 page
    2.6.33-stable review patch.  If anyone has any objections, please let us know.


    If cr0.wp=0, we have to allow the guest kernel access to a page with pte.w=0.
    We do that by setting spte.w=1, since the host cr0.wp must remain set so the
    host can write protect pages. Once we allow write access, we must remove
    user access otherwise we mistakenly allow the user to write the page.

    Reviewed-by: Xiao Guangrong <>
    Signed-off-by: Avi Kivity <>
    (cherry picked from commit 69325a122580d3a7b26589e8efdd6663001c3297)
    arch/x86/kvm/mmu.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/arch/x86/kvm/mmu.c
    +++ b/arch/x86/kvm/mmu.c
    @@ -1849,6 +1849,9 @@ static int set_spte(struct kvm_vcpu *vcp

    spte |= PT_WRITABLE_MASK;

    + if (!tdp_enabled && !(pte_access & ACC_WRITE_MASK))
    + spte &= ~PT_USER_MASK;
    * Optimization: for pte sync, if spte was writable the hash
    * lookup is unnecessary (and expensive). Write protection

     \ /
      Last update: 2010-07-30 19:49    [W:0.019 / U:38.952 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site