[lkml]   [2010]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[07/17] math-emu: correct test for downshifting fraction in _FP_FROM_INT()
    2.6.27-stable review patch.  If anyone has any objections, please let us know.


    From: Mikael Pettersson <>

    commit f8324e20f8289dffc646d64366332e05eaacab25 upstream.

    The kernel's math-emu code contains a macro _FP_FROM_INT() which is
    used to convert an integer to a raw normalized floating-point value.
    It does this basically in three steps:

    1. Compute the exponent from the number of leading zero bits.
    2. Downshift large fractions to put the MSB in the right position
    for normalized fractions.
    3. Upshift small fractions to put the MSB in the right position.

    There is an boundary error in step 2, causing a fraction with its
    MSB exactly one bit above the normalized MSB position to not be
    downshifted. This results in a non-normalized raw float, which when
    packed becomes a massively inaccurate representation for that input.

    The impact of this depends on a number of arch-specific factors,
    but it is known to have broken emulation of FXTOD instructions
    on UltraSPARC III, which was originally reported as GCC bug 44631

    Any arch which uses math-emu to emulate conversions from integers to
    same-size floats may be affected.

    The fix is simple: the exponent comparison used to determine if the
    fraction should be downshifted must be "<=" not "<".

    I'm sending a kernel module to test this as a reply to this message.
    There are also SPARC user-space test cases in the GCC bug entry.

    Signed-off-by: Mikael Pettersson <>
    Signed-off-by: David S. Miller <>
    Signed-off-by: Greg Kroah-Hartman <>

    include/math-emu/op-common.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/include/math-emu/op-common.h
    +++ b/include/math-emu/op-common.h
    @@ -793,7 +793,7 @@ do { \
    X##_e -= (_FP_W_TYPE_SIZE - rsize); \
    X##_e = rsize - X##_e - 1; \
    - if (_FP_FRACBITS_##fs < rsize && _FP_WFRACBITS_##fs < X##_e) \
    + if (_FP_FRACBITS_##fs < rsize && _FP_WFRACBITS_##fs <= X##_e) \
    __FP_FRAC_SRS_1(ur_, (X##_e - _FP_WFRACBITS_##fs + 1), rsize);\
    _FP_FRAC_DISASSEMBLE_##wc(X, ur_, rsize); \
    if ((_FP_WFRACBITS_##fs - X##_e - 1) > 0) \

     \ /
      Last update: 2010-07-30 19:09    [W:0.022 / U:5.608 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site