lkml.org 
[lkml]   [2010]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/6] block: remove BKL from partition code
    Date
    I don't see any reason why we need the BKL here.
    The functions blkdev_get, blkdev_put, blkpg_ioctl
    and blkdev_reread_part are the only remaining users
    of the big kernel lock in the block layer, and they
    all access the same fields of the bdev and gendisk
    structures, yet they always do so under the protection
    of bdev->bd_mutex.

    The open and close block_device_operations have all
    been converted to grab the BKL themselves, where
    necessary, so as far I can tell it should be safe
    to remove.

    If it is not, please explain why we still need it.

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    ---
    block/ioctl.c | 4 ----
    fs/block_dev.c | 10 ++--------
    2 files changed, 2 insertions(+), 12 deletions(-)

    diff --git a/block/ioctl.c b/block/ioctl.c
    index 60f477c..09fd7f1 100644
    --- a/block/ioctl.c
    +++ b/block/ioctl.c
    @@ -296,14 +296,10 @@ int blkdev_ioctl(struct block_device *bdev, fmode_t mode, unsigned cmd,
    bd_release(bdev);
    return ret;
    case BLKPG:
    - lock_kernel();
    ret = blkpg_ioctl(bdev, (struct blkpg_ioctl_arg __user *) arg);
    - unlock_kernel();
    break;
    case BLKRRPART:
    - lock_kernel();
    ret = blkdev_reread_part(bdev);
    - unlock_kernel();
    break;
    case BLKGETSIZE:
    size = bdev->bd_inode->i_size;
    diff --git a/fs/block_dev.c b/fs/block_dev.c
    index 99d6af8..693c2bf 100644
    --- a/fs/block_dev.c
    +++ b/fs/block_dev.c
    @@ -1345,13 +1345,12 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part)
    return ret;
    }

    - lock_kernel();
    restart:

    ret = -ENXIO;
    disk = get_gendisk(bdev->bd_dev, &partno);
    if (!disk)
    - goto out_unlock_kernel;
    + goto out;

    mutex_lock_nested(&bdev->bd_mutex, for_part);
    if (!bdev->bd_openers) {
    @@ -1431,7 +1430,6 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part)
    if (for_part)
    bdev->bd_part_count++;
    mutex_unlock(&bdev->bd_mutex);
    - unlock_kernel();
    return 0;

    out_clear:
    @@ -1444,9 +1442,7 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part)
    bdev->bd_contains = NULL;
    out_unlock_bdev:
    mutex_unlock(&bdev->bd_mutex);
    - out_unlock_kernel:
    - unlock_kernel();
    -
    + out:
    if (disk)
    module_put(disk->fops->owner);
    put_disk(disk);
    @@ -1515,7 +1511,6 @@ static int __blkdev_put(struct block_device *bdev, fmode_t mode, int for_part)
    struct block_device *victim = NULL;

    mutex_lock_nested(&bdev->bd_mutex, for_part);
    - lock_kernel();
    if (for_part)
    bdev->bd_part_count--;

    @@ -1540,7 +1535,6 @@ static int __blkdev_put(struct block_device *bdev, fmode_t mode, int for_part)
    victim = bdev->bd_contains;
    bdev->bd_contains = NULL;
    }
    - unlock_kernel();
    mutex_unlock(&bdev->bd_mutex);
    bdput(bdev);
    if (victim)
    --
    1.7.1


    \
     
     \ /
      Last update: 2010-07-03 23:51    [W:0.024 / U:0.228 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site