lkml.org 
[lkml]   [2010]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH net-next 2/3] drivers/net/bfin_mac.c: Use pr_<level>, netdev_<level>
    On Thu, Jul 29, 2010 at 19:58, Joe Perches wrote:
    > Add and use pr_fmt, pr_<level> and netdev_<level>

    your changelog says add pr_fmt, but i dont see it in the patch ...

    > @@ -833,8 +830,7 @@ static void bfin_tx_hwtstamp(struct net_device *netdev, struct sk_buff *skb)
    >                       (--timeout_cnt))
    >                        udelay(1);
    >                if (timeout_cnt == 0)
    > -                       printk(KERN_ERR DRV_NAME
    > -                                       ": fails to timestamp the TX packet\n");
    > +                       pr_err("failed to timestamp the TX packet\n");

    this func has a net_device, so cant you use netdev_err here ?

    > @@ -1102,8 +1097,7 @@ static void bfin_mac_rx(struct net_device *dev)
    >
    >        new_skb = dev_alloc_skb(PKT_BUF_SZ + NET_IP_ALIGN);
    >        if (!new_skb) {
    > -               printk(KERN_NOTICE DRV_NAME
    > -                      ": rx: low on mem - packet dropped\n");
    > +               pr_notice("rx: low on mem - packet dropped\n");

    same here

    otherwise this patch looks good
    -mike
    \
     
     \ /
      Last update: 2010-07-30 02:19    [W:0.021 / U:29.760 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site